Misc tiny changes #6046
Merged
Misc tiny changes #6046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The result is the same but clear [1] has slightly less code than resize [2] and signals better the intent IMHO. [1] https://github.com/gcc-mirror/gcc/blob/fb7fb646fa1631f429dcca7201f4a1a77f876667/libstdc%2B%2B-v3/include/bits/stl_vector.h#L1495 [2] https://github.com/gcc-mirror/gcc/blob/fb7fb646fa1631f429dcca7201f4a1a77f876667/libstdc%2B%2B-v3/include/bits/stl_vector.h#L934
…ind_last_of Recommendation from Clang-Tidy: https://clang.llvm.org/extra/clang-tidy/checks/performance-faster-string-find.html
scribam
commented
Jun 1, 2019
| @@ -207,7 +207,7 @@ namespace vk | |||
| { | |||
| if (!g_scratch_buffer) | |||
| { | |||
| // 32M disposable scratch memory | |||
| // 128M disposable scratch memory | |||
| g_scratch_buffer = std::make_unique<vk::buffer>(*g_current_renderer, 128 * 0x100000, | |||
There was a problem hiding this comment.
@kd-11 Can you confirm the value to set in the comment is 128 to match with the buffer's size (128 * 0x100000)?
There was a problem hiding this comment.
Yea, didn't change the comment when updating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.